Skip to content

feat(voice): let an error frame carry a transcribeToken - #698

Merged
moreih29 merged 1 commit into
developfrom
feat/voice-error-token
Nov 19, 2026
Merged

moreih29 merged 1 commit into
developfrom
feat/voice-error-token

Conversation

@moreih29

Copy link
Copy Markdown
Owner

Summary

A voice note session that ends on an error (provider failure, sign-out) gets no transcribeToken today, so its recording can never get the second pass. This lets the error frame carry the token as done does.

  • remote-protocol (0.14.0, unpublished): the server's error message takes an optional transcribeToken. Older peers drop it; a server that never sends one behaves as before.
  • Recorder: when an error brings a token, the take keeps it like a done token, so the existing save and second-pass flow picks it up. An error without one still only shows the toast.

The server side (sending the token on a provider error after at least 5 s of audio, and on sign-out) follows in nexus-cloud once this protocol version is published.

Tests

  • Protocol table: error with and without a token.
  • Main voice relay: an error with a token reaches the renderer unchanged.
  • bun run typecheck, bun run check:ci.

🤖 Generated with Claude Code

A note's session that ends in an error can now hand over the token, so
its saved recording can still get a second pass. The field is optional,
so 0.13.x peers keep working.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@moreih29
moreih29 merged commit 959f84c into develop Nov 19, 2026
7 checks passed
@moreih29
moreih29 deleted the feat/voice-error-token branch November 19, 2026 16:10
@moreih29 moreih29 mentioned this pull request Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant