Repository navigation
feat(voice): let an error frame carry a transcribeToken - #698
Merged
Merged
Conversation
A note's session that ends in an error can now hand over the token, so its saved recording can still get a second pass. The field is optional, so 0.13.x peers keep working. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A voice note session that ends on an error (provider failure, sign-out) gets no
transcribeTokentoday, so its recording can never get the second pass. This lets theerrorframe carry the token asdonedoes.remote-protocol(0.14.0, unpublished): the server'serrormessage takes an optionaltranscribeToken. Older peers drop it; a server that never sends one behaves as before.errorbrings a token, the take keeps it like adonetoken, so the existing save and second-pass flow picks it up. An error without one still only shows the toast.The server side (sending the token on a provider error after at least 5 s of audio, and on sign-out) follows in nexus-cloud once this protocol version is published.
Tests
errorwith and without a token.errorwith a token reaches the renderer unchanged.bun run typecheck,bun run check:ci.🤖 Generated with Claude Code